Skip to content

feat: ArrayData::new_null for ListView / LargeListView #8909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alamb merged 1 commit into from
Nov 23, 2025
Merged

feat: ArrayData::new_null for ListView / LargeListView #8909

alamb merged 1 commit into from
Nov 23, 2025

Conversation

@dqkqd
Copy link
Contributor

@dqkqd dqkqd commented Nov 23, 2025

Which issue does this PR close?

Rationale for this change

Add support for ListView and LargeListView in ArrayData::new_null

What changes are included in this PR?

Handle match arm + add testcase

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 23, 2025
@dqkqd dqkqd marked this pull request as draft November 23, 2025 04:16
@dqkqd dqkqd force-pushed the push-kvpmqxtykkwq branch 3 times, most recently from b2d5280 to 1434588 Compare November 23, 2025 04:26
@dqkqd dqkqd marked this pull request as ready for review November 23, 2025 04:26
@dqkqd dqkqd force-pushed the push-kvpmqxtykkwq branch from 1434588 to 34f0c9e Compare November 23, 2025 05:03
@dqkqd dqkqd changed the title feat: ArrayData::new_null for ListView / LargeListView` feat: ArrayData::new_null for ListView / LargeListView Nov 23, 2025
alamb
alamb approved these changes Nov 23, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @dqkqd

@alamb alamb merged commit 0424191 into apache:main Nov 23, 2025
27 checks passed
@alamb alamb mentioned this pull request Jan 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support DataType::ListView and DataType::LargeListView in ArrayData::new_null

2 participants

@dqkqd @alamb