Replace serde with serde_core when possible
#8558
Conversation
785f56e to
324dcfa
Compare
| where | ||
| D: Deserializer<'de>, | ||
| { | ||
| #[derive(Debug)] |
There was a problem hiding this comment.
my guess is that this is auto-generated code. I personally would prefer if we wouldn't nest structs/enums/impls/etc. into methods. It makes the code rather hard to read (for auto-generated code there are usually good reasons why this is done this way, e.g. due to shadowing).
There was a problem hiding this comment.
Definitely autogenerated-inspired, I'll pull all the inner definition outside.
324dcfa to
243f295
Compare
|
This currently is only semi-effective until BurntSushi/rust-csv#403 is merged and released. But if we try this upstream change by adding the following to [patch.crates-io]
csv = {git = "https://github.com/paolobarbolini/rust-csv.git", branch = "switch-to-serde-core"}and then we get all crates for a full-featured $ cargo tree -p arrow --all-features -e=no-devthen there's no |
Which issue does this PR close?
serdedependency toserde_corewhere applicable #8451.With this change, its possible to compile the core crate without pulling
serde_derive, which is will be only required forarrow-avroandarrow-schema/serde.Rationale for this change
Improve compile time and reduce number of dependencies and binary size in some cases.
What changes are included in this PR?
serde_corewhen possibleSerialize/Deserializefor canonical extension type metadata.Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No