Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 23, 2025

Which issue does this PR close?

Rationale for this change

Ci is failing on main after this PR is merged

Screenshot 2025-09-23 at 2 22 46 PM

Here is an example failure: https://github.com/apache/arrow-rs/actions/runs/17952764906/job/51056301800

error: useless conversion to the same type: `pyo3::Bound<'_, pyo3::PyAny>`
   --> arrow-pyarrow/src/lib.rs:181:12
    |
181 |         Ok(dtype.into())
    |            ^^^^^^^^^^^^ help: consider removing `.into()`: `dtype`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: useless conversion to the same type: `pyo3::Bound<'_, pyo3::PyAny>`
   --> arrow-pyarrow/src/lib.rs:217:12
    |
217 |         Ok(dtype.into())
    |            ^^^^^^^^^^^^ help: consider removing `.into()`: `dtype`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: useless conversion to the same type: `pyo3::Bound<'_, pyo3::PyAny>`
   --> arrow-pyarrow/src/lib.rs:253:12
    |
253 |         Ok(schema.into())
    |            ^^^^^^^^^^^^^ help: consider removing `.into()`: `schema`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

error: could not compile `arrow-pyarrow` (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...

I think it is a logical conflict

What changes are included in this PR?

Fix clippy

Are these changes tested?

We typically require tests for all PRs in order to:

  1. Prevent the code from being accidentally broken by subsequent changes
  2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?

Are there any user-facing changes?

If there are user-facing changes then we may require documentation to be updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.

Copy link
Contributor

@jecsand838 jecsand838 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was literally about to create an issue and push the same PR.

@alamb
Copy link
Contributor Author

alamb commented Sep 23, 2025

Thanks for the review @jecsand838 (and all the help so far getting arrow-avro so close)

@alamb alamb merged commit d03f1e6 into apache:main Sep 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants