arrow-row: Document dictionary handling #8168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ding-young and @LiaCastaneda, do you have a few minutes to review this PR and ensure this documentation also matches your understanding? |
ding-young
approved these changes
Aug 21, 2025
Contributor
ding-young
left a comment
There was a problem hiding this comment.
The code in the docs works fine, and I think the description matches my understanding. Thank you.
Contributor
Author
|
Thank you @ding-young for the review |
|
This lgmt too thank you again @alamb , sorry for the late reply, didn't have acces to my laptop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DictionaryArrays inStructArray/ListArray#7627Rationale for this change
It was not clear to me what the expected behavior for round trip through row converter was for DictionaryArrays, so let's document what @tustvold says here: #8067 (comment)
What changes are included in this PR?
Document expected behavior with english comments and doc test
Are these changes tested?
Yes (doctests)
Are there any user-facing changes?
More docs, no behavior change