refactor(avro): Use impl Write instead of dyn Write in encoder #8148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
alamb
approved these changes
Aug 15, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @Xuanwo
@jecsand838 could you also please review this? I know you are out until next week
jecsand838
approved these changes
Aug 15, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Writeratherdyn Writein Decoder #8142Rationale for this change
Help rust generate better code.
What changes are included in this PR?
Use
impl Writeinstead ofdyn WriteAre these changes tested?
In CI.
Are there any user-facing changes?
Yes, the public API changed.