chore: Use tempfile to replace hand-written utils functions #8147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
alamb
approved these changes
Aug 15, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @Xuanwo
cc @jecsand838
| arrow::compute::concat_batches(&schema, &input_batches).expect("concat input"); | ||
| let out_path = unique_temp_path("arrow_avro_roundtrip"); | ||
| let tmp = NamedTempFile::new().expect("create temp file"); | ||
| let out_path = tmp.into_temp_path(); |
Contributor
There was a problem hiding this comment.
I double checked that this auto cleans up. 👍
https://docs.rs/tempfile/latest/tempfile/struct.NamedTempFile.html#method.into_temp_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
tempfilecrate rather than custom temporary file generator in tests #8143Rationale for this change
Code Cleanup
What changes are included in this PR?
Use tempfile to replace hand-written utils functions
Are these changes tested?
tested in CI.
Are there any user-facing changes?
No