Skip to content

Conversation

@nathaniel-d-ef
Copy link
Contributor

Which issue does this PR close?

Part of #4886

Completes the breaking down/porting of the changes in #6965. This PR will be closed upon merge of this PR.

Rationale for this change

This change brings over the remaining integration tests present in the original PR, which validate the reader logic against the files from testing/data/avro. PRs containing this logic have already been merged (but are not yet released) which these tests now validate.

What changes are included in this PR?

The following files are now read in:

  • alltypes_dictionary.avro
  • alltypes_nulls_plain.avro
  • binary.avro
  • dict-page-offset-zero.avro
  • avro/list_columns.avro
  • nested_lists.snappy.avro
  • single_nan.avro
  • datapage_v2.snappy.avro
  • nested_records.avro
  • repeated_no_annotation.avro

Are these changes tested?

This PR consists of integration tests validating code merged recently into this crate. No changes in functionality are included.

Are there any user-facing changes?

N/A

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 22, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nathaniel-d-ef

😍 🏆

@alamb alamb merged commit b726b6f into apache:main Jul 22, 2025
24 checks passed
@jecsand838 jecsand838 deleted the avro-codec-integration branch July 22, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants