[Variant] Check pending before VariantObject::insert
#7786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 26, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @friendlymatthew and @harshmotw-db
| } | ||
| } | ||
|
|
||
| fn check_pending_field(&mut self) { |
Contributor
There was a problem hiding this comment.
I wonder if there is some sort of RAAI mechanism we can use to ensure that the pending field is completed automatically when the child ListBuilder or ObjectBuilder is dropped
That way the compiler can ensure this type of bug is not possible
Something like
/// If this is a builder for a nested object or list, on `Drop` this object will finish the
/// in progress field for the parent
enum PendingParent {
...
}
impl Drop for PendingParent {
List(...),
Object {
field_name: &str,
offset: usize
}
}Then we could create a field on the builder like this
struct ObjectBuilder {
...
pending: Option<PendingParent>,
}I think the biggest challenge would be sorting out the type lifetimes
Contributor
Author
There was a problem hiding this comment.
Interesting, I can take a stab at this
Contributor
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A follow up from #7778, we should make sure to check for pending fields before calling
ObjectBuilder::insert