Stop writing statistics to Parquet page headers by default, add option to enable #7594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
Author
|
Setting this to draft for now since it depends on #7555. |
alamb
approved these changes
Jun 9, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @etseidl -- I went over this PR carefully and I think it looks really nice.
I couldn't help myself so I also merged up from main to resolve a conflict, added an explicit test for writing page statistics, and tweaked some docs.
I think this is going to make a non trivial difference for people who store data using parquet-rs and enable page level statistics. THANK YOU
Contributor
|
I think we should wait for the next major release before merging this PR |
Contributor
Author
🤣 Thanks @alamb! Changes look great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reduces metadata bloat by not writing redundant statistics to each Parquet page header.
What changes are included in this PR?
Changes the meaning of
EnabledStatistics::Page. Currently this level means statistics will be written to the column chunk, page header, and column index. With this PRPagenow means writing to the column chunk and column index. Writing to the page header can be enabled using an addedwrite_page_header_statisticswriter option.Also adds some command line switches to the
parquet-rewritetool.Are there any user-facing changes?
No breaking API changes, but an added option and behavior change.
Specifically, statistics are no longer written to data Page headers by default. If you want them (not common) you will have to explictly enable doing so