Minor: refine row selection example more #5850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 6, 2024
| /// Select 50-100 (scan rows 50-100 in row group 2) | ||
| /// Skip 50 (skip the first 50 rows in row group 2) | ||
| /// Select 50 (scan rows 50-100 in row group 2) | ||
| /// Skip 900 (skip the remaining rows in row group 2) |
Contributor
Author
There was a problem hiding this comment.
Not showing this "skip remaining rows in row group" I think was part of what was confusing
Contributor
There was a problem hiding this comment.
I don't remember if this is actually required, the readers actually trim trailing skips, but good to document regardless
tustvold
approved these changes
Jun 11, 2024
Contributor
Author
|
Thanks @tustvold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #5824
Rationale for this change
In discussing how row selections interacted with the row group selection with @advancedxy on apache/datafusion#10738 (see https://github.com/apache/datafusion/pull/10738/files#r1628074742) it became clear that the example could be improved to better explain what is going on
What changes are included in this PR?
Refine example added in #5824 to better show how how skip / select works at the end of a row group.
Are there any user-facing changes?
Moar docs, no functional change