JSON: write struct array nulls as null #5133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Nov 28, 2023
arrow-json/src/writer.rs
Outdated
| let json_values = jsonmaps | ||
| .into_iter() | ||
| .map(|maybe_map| { | ||
| if let Some(map) = maybe_map { |
Contributor
Author
There was a problem hiding this comment.
Refactored to use map and unwrap_or
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes apache/arrow-rs-object-store#109
Rationale for this change
What changes are included in this PR?
Nulls in struct arrays are written as
nullin JSON, where previously was written as{}(or filled with nulls for the keys if explicit nulls are written)Are there any user-facing changes?