Skip to content

Conversation

@tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Continues to work to make these types more easy to use

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 12, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice cleanup 👍

pub fn is_null(input: &dyn Array) -> Result<BooleanArray, ArrowError> {
let values = match input.nulls() {
None => NullBuffer::new_null(input.len()).into_inner(),
None => BooleanBuffer::new_unset(input.len()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clever

@alamb alamb changed the title Further BooleanBuffer Constructors Add BooleanBuffer::new_unset and BooleanBuffer::new_set constructors Jun 12, 2023
@alamb alamb changed the title Add BooleanBuffer::new_unset and BooleanBuffer::new_set constructors Add BooleanBuffer::new_unset and BooleanBuffer::new_set and BooleanArray::new_null constructors Jun 12, 2023
@tustvold tustvold merged commit 2c71135 into apache:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants