Skip to content

Update verify_release.sh to work with 30.0.0 via workaround#3413

Merged
alamb merged 1 commit into
apache:masterfrom
alamb:alamb/hack_verify
Dec 30, 2022
Merged

Update verify_release.sh to work with 30.0.0 via workaround#3413
alamb merged 1 commit into
apache:masterfrom
alamb:alamb/hack_verify

Conversation

@alamb

@alamb alamb commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

closes #3410

Rationale for this change

parquet now has an optional dependence on object_store but object_store is not part of the tarball and thus the verify script fails

What changes are included in this PR?

A hack to the verify_release script to fix the verification and remove the path marker in the object store dependency declaration

@tustvold has noted that rather than changing the verify script the actual tarball should probably be fixed (aka so that it does not have references to path. I will write up a follow on ticket for this issue

Are there any user-facing changes?

No

@tustvold tustvold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this, but if it unblocks things we can fix it properly later

@alamb

alamb commented Dec 30, 2022

Copy link
Copy Markdown
Contributor Author

I tested that this script can successfully verify 30.0.0 rc 1

@alamb

alamb commented Dec 30, 2022

Copy link
Copy Markdown
Contributor Author

Filed #3414 to track the underlying issue

@alamb alamb changed the title Update verify_release.sh to work with 30.0.0 Update verify_release.sh to work with 30.0.0 via workaround Dec 30, 2022
@alamb alamb merged commit 9398af6 into apache:master Dec 30, 2022
@alamb alamb deleted the alamb/hack_verify branch December 30, 2022 12:29
@ursabot

ursabot commented Dec 30, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 9b57621 and contender = 9398af6. 9398af6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold added arrow Changes to the arrow crate development-process Related to development process of arrow-rs labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verification failure on 30.0.0 RC1 -- failure to read object_store path while building parquet

3 participants