Add a cast test case for decimal negative scale#3203
Conversation
tustvold
left a comment
There was a problem hiding this comment.
Although I wonder if this should be returning an error?
Why? I think this is correct behavior. |
|
For other types we error on truncation, so I figured we would do the same here, if you're fine with truncation why not just use floats? I dunno, I'm not very knowledgeable about decimals, so happy to defer to you 😅 |
|
This follows current rounding behavior when casting between decimals with different scales. It rounds to nearest neighbor and round up when both neighbors are equidistant. I added one more test to make it more clear. |
|
Benchmark runs are scheduled for baseline = 8db21ea and contender = 1daf7d3. 1daf7d3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
Clarifying the question at #3139 (comment).
What changes are included in this PR?
Are there any user-facing changes?