Skip to content

Recurse into Dictionary value type in DataType::is_nested#3083

Merged
tustvold merged 1 commit into
apache:masterfrom
tustvold:include-dictionary-is-nested
Nov 10, 2022
Merged

Recurse into Dictionary value type in DataType::is_nested#3083
tustvold merged 1 commit into
apache:masterfrom
tustvold:include-dictionary-is-nested

Conversation

@tustvold

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

https://github.com/apache/arrow-rs/pull/3080/files#r1019551725

What changes are included in this PR?

Recurses is_nested check into dictionary values

Are there any user-facing changes?

@tustvold tustvold added the api-change Changes to the arrow API label Nov 10, 2022
@tustvold tustvold requested a review from viirya November 10, 2022 19:57
@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 10, 2022

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tustvold tustvold merged commit ed20bf1 into apache:master Nov 10, 2022
@ursabot

ursabot commented Nov 10, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = ce5e26f and contender = ed20bf1. ed20bf1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants