Skip to content

feat: add OwnedRow#3079

Merged
tustvold merged 1 commit into
apache:masterfrom
crepererum:crepererum/issue3078
Nov 10, 2022
Merged

feat: add OwnedRow#3079
tustvold merged 1 commit into
apache:masterfrom
crepererum:crepererum/issue3078

Conversation

@crepererum

@crepererum crepererum commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #3078.

Rationale for this change

Providing a way to move/clone a row without referencing the whole buffer.

What changes are included in this PR?

New type OwnedRow.

Are there any user-facing changes?

No breaking change, just a new type.

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 10, 2022
@crepererum

crepererum commented Nov 10, 2022

Copy link
Copy Markdown
Contributor Author

Windows CI fails w/

 failures:

---- column::reader::decoder::tests::test_skip stdout ----
thread 'column::reader::decoder::tests::test_skip' panicked at 'assertion failed: `(left == right)`
  left: `43`,
 right: `81`', parquet\src\column\reader\decoder.rs:506:21


failures:
    column::reader::decoder::tests::test_skip

test result: FAILED. 578 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 15.16s

error: test failed, to rerun pass `-p parquet --lib`

I'm pretty sure this is unrelated.

alamb
alamb reviewed Nov 10, 2022
View reviewed changes

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

I suggest we add some basic tests for them (if @tustvold agrees to the basic premise) that verify that the derived impls are consistent with the non owned version

tustvold
tustvold approved these changes Nov 10, 2022
View reviewed changes

@tustvold tustvold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the derived impls simply delegate to Row I'm happy without tests

@tustvold tustvold merged commit 885a361 into apache:master Nov 10, 2022
@ursabot

ursabot commented Nov 10, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 9f14683 and contender = 885a361. 885a361 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb left review comments

@tustvold tustvold tustvold approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Row Format: Option to detach/own a row

4 participants

@crepererum @ursabot @alamb @tustvold