Skip to content

Update arrow-flight subcrates (#3044)#3052

Merged
tustvold merged 2 commits into
apache:masterfrom
tustvold:arrow-flight-sub-crates
Nov 10, 2022
Merged

Update arrow-flight subcrates (#3044)#3052
tustvold merged 2 commits into
apache:masterfrom
tustvold:arrow-flight-sub-crates

Conversation

@tustvold

@tustvold tustvold commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #3044

Rationale for this change

Updates arrow-flight to depend only on sub crates

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow-flight Changes to the arrow-flight crate label Nov 8, 2022
@tustvold tustvold force-pushed the arrow-flight-sub-crates branch from f02d62c to ba7dea8 Compare November 9, 2022 00:11
Comment thread .github/workflows/arrow_flight.yml Outdated
@tustvold tustvold requested a review from viirya November 9, 2022 09:22
@tustvold

tustvold commented Nov 9, 2022

Copy link
Copy Markdown
Contributor Author

Marking as draft pending #3053

@tustvold tustvold marked this pull request as draft November 9, 2022 19:33
@tustvold tustvold force-pushed the arrow-flight-sub-crates branch from f16f2af to 21895c3 Compare November 10, 2022 03:06
@tustvold tustvold marked this pull request as ready for review November 10, 2022 03:08
Comment on lines -39 to -40
- arrow-csv/**
- arrow-json/**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by mistake?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time arrow-flight had a transitive dependency on them via arrow

/// * `Ok(None)` when message type mismatch
/// * `Err` when parse failed
fn unpack<M: ProstMessageExt>(&self) -> ArrowResult<Option<M>>;
fn unpack<M: ProstMessageExt>(&self) -> Result<Option<M>, ArrowError>;

@viirya viirya Nov 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you defined ArrowResult at arrow-flight/src/lib.rs, aren't we going to use it in arrow-flight crate?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I've been trying to avoid aliasing Result, it was necessary in lib.rs due to name collisions

@tustvold tustvold merged commit 132152c into apache:master Nov 10, 2022
@ursabot

ursabot commented Nov 10, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8d364fe and contender = 132152c. 132152c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow-flight Changes to the arrow-flight crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants