Skip to content

Split out arrow-json (#3044)#3049

Merged
tustvold merged 5 commits into
apache:masterfrom
tustvold:split-out-arrow-json
Nov 9, 2022
Merged

Split out arrow-json (#3044)#3049
tustvold merged 5 commits into
apache:masterfrom
tustvold:split-out-arrow-json

Conversation

@tustvold

@tustvold tustvold commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Part of #3044

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 8, 2022
Comment thread arrow/Cargo.toml
Comment on lines -67 to -69
lexical-core = { version = "^0.8", default-features = false, features = ["write-integers", "write-floats", "parse-integers", "parse-floats"] }
multiversion = { version = "0.6.1", default-features = false }
bitflags = { version = "1.2.1", default-features = false }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just drive-by-fixes. They are no longer needed by the top-level crate

Comment thread arrow-json/src/reader.rs Outdated
//! use std::fs::File;
//! use std::io::BufReader;
//! use std::sync::Arc;
//! ```no_run

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why change to no_run?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops need to revert

Comment thread arrow-json/src/reader.rs
Comment on lines -2081 to -2084
File::open("test/data/uk_cities_with_headers.csv").unwrap(),
),
None,
);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We drop this file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it just isn't part of the arrow-json test data

@tustvold tustvold merged commit 8d75101 into apache:master Nov 9, 2022
@ursabot

ursabot commented Nov 9, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = fe3318b and contender = 8d75101. 8d75101 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants