Skip to content

Add pow to i256#2955

Merged
viirya merged 1 commit into
apache:masterfrom
viirya:i256_pow
Oct 27, 2022
Merged

Add pow to i256#2955
viirya merged 1 commit into
apache:masterfrom
viirya:i256_pow

Conversation

@viirya

@viirya viirya commented Oct 27, 2022

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #2954.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Oct 27, 2022

@tustvold tustvold left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Comment thread arrow-buffer/src/bigint.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for exp in vec![0, 1, u32::MAX].into_iter() {
for exp in vec![0, 1,3, 8, u32::MAX].into_iter() {

Just to get a bit more coverage

@viirya viirya force-pushed the i256_pow branch 2 times, most recently from 015b78e to ea06975 Compare October 27, 2022 19:11
@viirya viirya merged commit 63417b1 into apache:master Oct 27, 2022
@ursabot

ursabot commented Oct 27, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 4e1247e and contender = 63417b1. 63417b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pow to i256

3 participants