Skip to content

Speedup string equal/not equal to empty string, cleanup like/ilike kernels, fix escape bug#2743

Merged
Dandandan merged 8 commits into
apache:masterfrom
Dandandan:speedup_string_equal_empty
Sep 16, 2022
Merged

Speedup string equal/not equal to empty string, cleanup like/ilike kernels, fix escape bug#2743
Dandandan merged 8 commits into
apache:masterfrom
Dandandan:speedup_string_equal_empty

Conversation

@Dandandan

@Dandandan Dandandan commented Sep 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #2574 #2744 #2745

Rationale for this change

Fixes a bug, cleans up some code and improves performance for empty string:

equal_string_scalar_empty_512
                        time:   [802.37 ns 806.33 ns 810.99 ns]
                        change: [-21.974% -20.704% -19.429%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  1 (1.00%) low severe
  4 (4.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Sep 16, 2022
@Dandandan Dandandan changed the title Speedup string equal empty Speedup string equal empty, make like/ilike kernel generic Sep 16, 2022
@Dandandan Dandandan changed the title Speedup string equal empty, make like/ilike kernel generic Speedup string equal empty, cleanup like/ilike kernels Sep 16, 2022
@Dandandan Dandandan changed the title Speedup string equal empty, cleanup like/ilike kernels Speedup string equal empty, cleanup like/ilike kernels, fix escape bug Sep 16, 2022
@Dandandan Dandandan changed the title Speedup string equal empty, cleanup like/ilike kernels, fix escape bug Speedup string equal/not equal to empty string, cleanup like/ilike kernels, fix escape bug Sep 16, 2022
@Dandandan Dandandan merged commit 968a767 into apache:master Sep 16, 2022
@ursabot

ursabot commented Sep 16, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = f572ec1 and contender = 968a767. 968a767 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

This was referenced Sep 16, 2022
Closed
Closed
Closed
@tustvold tustvold mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dandandan @ursabot @tustvold