Skip to content

Logging Support #1495

@tustvold

Description

@tustvold

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently arrow and parquet do not have any log instrumentation, and I have frequently found myself adding logging to track down a problem, only to then have to remove this logging for the final PR.

Describe the solution you'd like

This log crate is well-supported within the Rust ecosystem and allows filtering out callsites at both runtime and compile time. It is also used downstream by DataFusion. This would allow adding instrumentation to the code that can be enabled for debugging a problem, and then disabled when no longer desired.

Describe alternatives you've considered

There is also the tracing ecosystem, but this is likely significant overkill given neither crate makes significant use of tokio. Fortunately tracing-log provides an adapter should a downstream wish to use tokio-tracing, whilst allowing arrow, etc... to use the significantly simpler log ecosystem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementAny new improvement worthy of a entry in the changelog

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions