Skip to content

fix: Force static library build on Windows when building with Meson#496

Merged
paleolimbot merged 1 commit intoapache:mainfrom
WillAyd:meson-windows-compat
May 29, 2024
Merged

fix: Force static library build on Windows when building with Meson#496
paleolimbot merged 1 commit intoapache:mainfrom
WillAyd:meson-windows-compat

Conversation

@WillAyd
Copy link
Copy Markdown
Contributor

@WillAyd WillAyd commented May 28, 2024

May not necessarily fix #495 but reasonably defers trying to solve

Basically the suggestion of the great @eli-schwartz

@paleolimbot paleolimbot changed the title fix: Force static library build on Windows fix: Force static library build on Windows when building with Meson May 29, 2024
Copy link
Copy Markdown
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paleolimbot paleolimbot merged commit 8171104 into apache:main May 29, 2024
@WillAyd WillAyd deleted the meson-windows-compat branch May 29, 2024 00:39
@paleolimbot paleolimbot added this to the nanoarrow 0.6.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export symbols from C library when compiling as a shared library on Windows

2 participants