fix(internal): fix assertion on undefined behavior#602
Merged
zeroshade merged 1 commit intoapache:mainfrom Dec 9, 2025
Merged
Conversation
zeroshade
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Prior to this PR,
TestMul_64bitininternal/utils/math_64bit_test.gofails on macOS aarch64. This wasn't caught on CI because there's no CI job for macOS aarch64. The behavior under test is technically undefined behavior (int(NaN)is UB).What changes are included in this PR?
Just to keep the change small, I did the minimum necessary to make the assertion pass on all platforms.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Closes #413