chore(arrow): remove most lock copies#362
Merged
zeroshade merged 3 commits intoapache:mainfrom Apr 30, 2025
Merged
Conversation
lidavidm
approved these changes
Apr 28, 2025
lidavidm
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#326 moved to using
atomic.Int64{]for the refcount, as a result we found many places that we were copying the value. For linting reasons we should remove those.What changes are included in this PR?
Utilizing generics to clean up the dictionary array code significantly, along with removing most of the cases where we were copying the refcount which contains a lock.
Are these changes tested?
Yes, the existing unit tests cover it all.
Are there any user-facing changes?
Nope.