feat(parquet): Add support for Page Indexes#223
Merged
zeroshade merged 6 commits intoapache:mainfrom Jan 9, 2025
Merged
Conversation
kou
reviewed
Dec 21, 2024
Member
kou
left a comment
There was a problem hiding this comment.
(Sorry, I couldn't review this carefully... I took a look at all changes but I don't have enough knowledge of the Parquet specification and Go. And this change is too large for me... I hope that others can review this.)
Member
Author
Member
Author
|
I'd like to get this in before I kick off the next release in the next week or so. Would anyone be free to do a review soon? |
lidavidm
approved these changes
Jan 9, 2025
Member
Author
|
Thanks for the review @lidavidm!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Adds support for writing and retrieving Page Indexes from parquet files
What changes are included in this PR?
Added new writer properties to enable writing PageIndexes either as default or for specific columns.
Added
RowGroupPageIndexReader,ColumnIndexReader,OffsetIndexReaderto access page index information.Are these changes tested?
Yes, extensive unit tests have been added including round trip tests and encryption/decryption tests.
Are there any user-facing changes?
no. Just new functions available.
closes #33