fix: Antarctica/Vostok tz offset changed in chrono-tz 0.8.5
#8677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antarctica/Vostok tz offset changed in chrono-tz 0.8.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes --.
Rationale for this change
What changes are included in this PR?
Due to recently changed Antarctica/Vostok tz offset (see commit which also affected fresh chrono-tz 0.8.5 release) the test with this tz started failing.
In order not to affect existsing 0.8.4 chono-tz on someones machine, and successfully complete all tests on github runners -- the suggestion is to just delete this tz from test (I suppose three cases will be enought for testing string TZ parsing).
Are these changes tested?
Only tests has been modified
Are there any user-facing changes?
No