Skip to content

Conversation

@mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

As discussed in the link, current documentation for group by rewrite is missing. And rationale for it was not clear. This PR updates the docstring of the get_updated_group_by_exprs function such that adds its usage, and its motivation is more clear.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mustafasrepo

@alamb alamb merged commit 350d4ca into apache:main Jul 27, 2023
@mustafasrepo mustafasrepo deleted the doc/update_grouo_by_rewrite branch July 28, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants