Skip to content

fix(go/adbc/driver/snowflake): split files properly after reaching targetSize on ingestion#2026

Merged
zeroshade merged 5 commits intoapache:mainfrom
joellubi:gh-1997-batching
Jul 29, 2024
Merged

fix(go/adbc/driver/snowflake): split files properly after reaching targetSize on ingestion#2026
zeroshade merged 5 commits intoapache:mainfrom
joellubi:gh-1997-batching

Conversation

@joellubi
Copy link
Copy Markdown
Member

@joellubi joellubi commented Jul 18, 2024 •
edited
Loading

Fixes: #1997

Core Changes

  • Change ingestion writeParquet function to use unbuffered writer, skipping 0-row records to avoid recurrence of adbc_ingest() is dropping rows in Snowflake #1847
  • Use parquet writer's internal RowGroupTotalBytesWritten() method to track output file size in favor of limitWriter
  • Unit test to validate that file cutoff occurs precisely when expected

Secondary Changes

  • Bump arrow dependency to v18 to pull in the changes from ARROW-43326
  • Fix flightsql test that depends on hardcoded arrow version

@joellubi joellubi marked this pull request as ready for review July 19, 2024 16:48
@joellubi joellubi requested a review from zeroshade as a code owner July 19, 2024 16:48
@github-actions github-actions bot added this to the ADBC Libraries 14 milestone Jul 19, 2024
@joellubi joellubi mentioned this pull request Jul 19, 2024
Closed
zeroshade
zeroshade reviewed Jul 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a rebase please? I believe the version was already bumped to v18 for Arrow

@joellubi
Copy link
Copy Markdown
Member Author

joellubi commented Jul 29, 2024

Can you do a rebase please? I believe the version was already bumped to v18 for Arrow

Sure, just rebased and applied your comment.

@joellubi joellubi requested a review from zeroshade July 29, 2024 20:35
@zeroshade zeroshade merged commit d05e1ba into apache:main Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 14

Development

Successfully merging this pull request may close these issues.

go/adbc/driver/flightsql: Default Value (10 MB) For adbc.snowflake.rpc.ingest_target_file_size Not Used In 1.1.0

2 participants

@joellubi @zeroshade