Skip to content

ARROW-11983: [Python] Avoid ImportError calling from_pandas in threaded code #9789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorisvandenbossche wants to merge 2 commits into from
Closed

ARROW-11983: [Python] Avoid ImportError calling from_pandas in threaded code #9789

jorisvandenbossche wants to merge 2 commits into from

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Mar 24, 2021

No description provided.

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 24, 2021

@pitrou do you think it is worth it trying to construct a test for this?

@github-actions
Copy link

github-actions bot commented Mar 24, 2021

https://issues.apache.org/jira/browse/ARROW-11983

@pitrou
Copy link
Member

pitrou commented Mar 24, 2021

Does this actually fix the issue (were you able to reproduce)?

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 24, 2021 •
edited
Loading

Good question .. I could reproduce it, and at the time I also checked that adding import concurrent.futures.thread to the script fixed the issue. But so the change in this PR itself actually doesn't fix it. I still need to add a top-level import concurrent.futures.thread or from concurrent.futures import ThreadPoolExecutor as well. Just moving the from concurrent import futures to top-level is not enough to fix it.

@pitrou
Copy link
Member

pitrou commented Mar 24, 2021

That's what I thought :-)

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Mar 25, 2021

Yeah, I should have checked again ;)

pitrou
pitrou approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jorisvandenbossche jorisvandenbossche deleted the ARROW-11983 branch March 25, 2021 12:53
@asfimport asfimport mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorisvandenbossche @pitrou