Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Feb 22, 2021

Also ensure that SortIndices sets the result null_count to 0.

@pitrou pitrou requested a review from bkietz February 22, 2021 16:47
@kszucs
Copy link
Member

kszucs commented Feb 22, 2021

@pitrou are you sure that the ticket number is right?

@pitrou pitrou changed the title ARROW-9006: [C++] Fix Take() with no validity bitmap but unknown null count ARROW-11694: [C++] Fix Take() with no validity bitmap but unknown null count Feb 22, 2021
@pitrou
Copy link
Member Author

pitrou commented Feb 22, 2021

@kszucs No, you're right, thank you. Just fixed it in the summary line.

…l count

Also ensure that SortIndices sets the result null_count to 0.
@pitrou pitrou force-pushed the ARROW-9006-take-empty-null-bitmap branch from 7e4a3b0 to 865cd3c Compare February 22, 2021 16:57
Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@github-actions
Copy link

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants