Skip to content

ARROW-11724: [C++] Resolve namespace collisions with protobuf 3.15 #9542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xhochy wants to merge 1 commit into from
Closed

ARROW-11724: [C++] Resolve namespace collisions with protobuf 3.15 #9542

xhochy wants to merge 1 commit into from

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Feb 21, 2021

Renames our alias to afpb to not clash with protobuf's definition.

Original error:

../src/arrow/flight/server.cc:63:11: error: redefinition of 'pb' as an alias for a different namespace
namespace pb = arrow::flight::protocol;
          ^
/Users/uwe/mambaforge/conda-bld/arrow-cpp-ext_1613940663852/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/include/google/protobuf/port.h:44:11: note: previously defined as an alias for 'protobuf_future_namespace_placeholder'
namespace pb = ::protobuf_future_namespace_placeholder;
          ^
1 error generated.

@github-actions
Copy link

github-actions bot commented Feb 21, 2021

https://issues.apache.org/jira/browse/ARROW-11724

@xhochy
Copy link
Member Author

xhochy commented Feb 21, 2021

@github-actions autotune

@xhochy xhochy closed this Feb 21, 2021
@xhochy xhochy reopened this Feb 21, 2021
@cyb70289 cyb70289 mentioned this pull request Feb 22, 2021
Closed
pitrou
pitrou reviewed Feb 22, 2021
View reviewed changes
cpp/src/arrow/flight/client.cc Outdated
Copy link
Member

@pitrou pitrou Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you put the "namespace pb" alias inside the arrow namespace below?
There is no reason to believe that top-level afpb won't conflict with another library.

Copy link
Member Author

@xhochy xhochy Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that worked. CI is green again.

Copy link
Member Author

@xhochy xhochy Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that worked. CI is green again.

@xhochy xhochy force-pushed the ARROW-11724 branch 2 times, most recently from 2742204 to 5ef559b Compare February 22, 2021 16:37
@xhochy xhochy closed this Feb 22, 2021
@xhochy xhochy reopened this Feb 22, 2021
@xhochy xhochy closed this Feb 22, 2021
@xhochy xhochy reopened this Feb 22, 2021
pitrou
pitrou approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @xhochy

@pitrou pitrou closed this in 06c795c Feb 23, 2021
@xhochy xhochy deleted the ARROW-11724 branch February 23, 2021 09:52
@ianmcook
Copy link
Member

ianmcook commented Apr 27, 2021 •
edited
Loading

The Homebrew formula patch that this PR obviates the need for is removed in Homebrew/homebrew-core#76060

@asfimport asfimport mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++ Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xhochy @ianmcook @pitrou