Skip to content

Conversation

@bkietz
Copy link
Member

@bkietz bkietz commented Jan 7, 2021

See also: #8894

The "project" compute function is not really intended for direct use; it's primarily a convenience for exposing expressions to projection: https://issues.apache.org/jira/browse/ARROW-11174

As such, maybe it should be hidden instead of exposed to python?

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

@bkietz
Copy link
Member Author

bkietz commented Jan 8, 2021

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @bkietz

@jorisvandenbossche
Copy link
Member

As such, maybe it should be hidden instead of exposed to python?

If it is not intended (yet) for direct use, I think that would be a good idea (or at least clearly mention this in the docstring).

(see also my reservations about the name at #8894 (comment))

@bkietz
Copy link
Member Author

bkietz commented Jan 11, 2021

Merging.
Follow up to hide/rename/... https://issues.apache.org/jira/browse/ARROW-11206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants