ARROW-11043: [C++] Add "is_nan" kernel #9023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyb70289
reviewed
Dec 28, 2020
cyb70289
reviewed
Dec 28, 2020
cyb70289
reviewed
Dec 28, 2020
cyb70289
reviewed
Dec 29, 2020
Fix following reviewer's comment: * iff not a typo, * test for nulls, * update docs/source/cpp/compute.rst Then: * apply clang-format to pass CI lint check.
Fix following reviewer's comment:
* update docs/source/cpp/compute.rst
Fix following reviewer's comment: * Update "since version number" * Improve kernel documentation (remove "according to std::isnan()") * Improve code style (replace typedef aliases by using aliases) * Minor fix (float32 literal without f suffix)
Fix following reviewer's comment: * Move <cmath> include from common.h to kernel source.
Contributor
Author
|
PR rebased! |
Member
|
Thanks a lot @bu2 ! |
Contributor
Author
|
Thanks to @cyb70289 for the initial review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "is_nan" kernel to check for NaN "equality" for FloatArray and DoubleArray (based on std::isnan()). The kernel signature is based on "is_null" kernel so I put my code in arrow/compute/kernels/scalar_validity.cc... but the implementation take some inspiration from "compare" kernel.