Skip to content

ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string]) #8628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maartenbreddels wants to merge 11 commits into from
Closed

ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string]) #8628

maartenbreddels wants to merge 11 commits into from

Conversation

@maartenbreddels
Copy link
Contributor

@maartenbreddels maartenbreddels commented Nov 10, 2020 •
edited by pitrou
Loading

No description provided.

maartenbreddels
maartenbreddels commented Nov 10, 2020
View reviewed changes
cpp/src/arrow/compute/kernels/scalar_fill_null.cc Outdated
Copy link
Contributor Author

@maartenbreddels maartenbreddels Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally forgot the +1 here, and everything worked. Does CI include valgrind, and should it pick this up?

Copy link
Member

@pitrou pitrou Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The +1 should not be necessary. This is the number of values appended, not the number of offsets.

@github-actions
Copy link

github-actions bot commented Nov 10, 2020

https://issues.apache.org/jira/browse/ARROW-9489

pitrou
pitrou reviewed Nov 10, 2020
View reviewed changes
pitrou
pitrou reviewed Nov 10, 2020
View reviewed changes
@maartenbreddels
Copy link
Contributor Author

maartenbreddels commented Nov 10, 2020

Looking at the implementation of VisitArrayDataInline, which is quite similar to what is being done in FillNullFunctor<Type, enable_if_t<is_number_type<Type>::value>>, I don't see much room for improvement.

pitrou
pitrou reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments. Thank you for this PR!

cpp/src/arrow/compute/kernels/scalar_fill_null.cc Outdated
Copy link
Member

@pitrou pitrou Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling MayHaveNulls, just compute the null count and check it here.

@maartenbreddels
Copy link
Contributor Author

maartenbreddels commented Nov 13, 2020

@pitrou i think this is ready to go/review.

pitrou
pitrou approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will merge. Thank you @maartenbreddels !

@pitrou pitrou closed this in 7c509a6 Nov 16, 2020
@maartenbreddels maartenbreddels mentioned this pull request Jan 25, 2021
Merged
5 tasks
@asfimport asfimport mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maartenbreddels @pitrou