ARROW-8601: [Go][Flight] Implementations Flight RPC server and client #8175
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
Tagging the people that were on the previous PR for visibility: @sbinet @mindhash @stuartcarnie could any / all of you have a look / review? Thanks much! |
|
Bump. Can someone please give this a review so we can get this merged? Thanks. |
|
Agree it would be good for this to be reviewed / merged. Can you rebase and get a more complete CI build? |
f5d6c07 to
7c5f442
Compare
|
@wesm rebased |
|
@wesm as far as i can tell the two checks that are failing are unrelated to this PR. I have ideas for further exploring / adding more functionality for the FlightRPC stuff, but I don't want to put too much into this PR and would rather further development be a separate PR to reach more feature parity with the C++ / Python versions of the flight server/client. I'm actually currently building out a project at work that will be utilizing the Go flight rpc server and client which was the impetus for me building this out. So anything you can do to help get this reviewed and pushed along would be greatly appreciated. Thanks much! |
sbinet
left a comment
There was a problem hiding this comment.
just a quick, drive-by, review.
I apologize, but I've switched teams at work and my new position doesn't involve much using Arrow, so that's only free cycles.
sorry.
fc6c3b7 to
8e48e76
Compare
wesm
left a comment
There was a problem hiding this comment.
+1. I will go ahead and merge since CI is passing. Thanks @zeroshade!
|
Yes, thanks! |
These files should have been added to the Just put up a pr #8273 |
Built out from #6731 with some inspiration from the existing Reader/Writer and the C++ Flight implementation. Still need to build out the tests some more, but would like to get opinions and thoughts on what I've got so far as I continue to build it out.