Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Jul 30, 2020

While it technically is still using pandas during the conversion it exposes the to_numpy() method.

Also refactored the chunked array construction to support more flexible input, see the test case.

@github-actions
Copy link

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it technically is still using pandas during the conversion it exposes the to_numpy() method.

I think it is actually not using pandas (although the ConvertChunkedArrayToPandas name is certainly confusing in that case, but I thought this also worked without pandas being present. It just converts the arrow data to an array or dict that is in the appropriate form to convert to pandas)

@pitrou
Copy link
Member

pitrou commented Aug 5, 2020

@kszucs Can you rebase this PR? Hopefully it will fix AppVeyor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if there's zero chunk, or do you need to pass the type explicitly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pass the type explicitly, fixing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either "All array chunks" (plural) or "Each array chunk" (singular).

@kszucs
Copy link
Member Author

kszucs commented Aug 10, 2020

@pitrou rebased and addressed your comments

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants