ARROW-9495: [C++] Equality assertions don't handle Inf / -Inf properly #7826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1943d5 to
d7766f3
Compare
kiszk
reviewed
Jul 25, 2020
cpp/src/arrow/array/array_test.cc
Outdated
Contributor
Author
There was a problem hiding this comment.
Removed. Thanks for your kind reminder.
Member
|
Looks good to me |
Contributor
Author
pitrou
requested changes
Aug 13, 2020
cpp/src/arrow/compare.cc
Outdated
Member
There was a problem hiding this comment.
You must also change the nans_equal path above.
Contributor
Author
There was a problem hiding this comment.
Revised accordingly. Thanks a lot for your kind reminder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/ARROW-9495