Skip to content

ARROW-7010: [C++] Implement decimal-to-float casts #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-7010: [C++] Implement decimal-to-float casts #7618

pitrou wants to merge 1 commit into from

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jul 2, 2020

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

https://issues.apache.org/jira/browse/ARROW-7010

@pitrou pitrou force-pushed the ARROW-7010-cast-decimal-to-float branch 4 times, most recently from 4c7db72 to b7e03b1 Compare July 2, 2020 18:52
fsaintjacques
fsaintjacques approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@fsaintjacques fsaintjacques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A well crafted unit test suite.

@pitrou pitrou force-pushed the ARROW-7010-cast-decimal-to-float branch from b7e03b1 to eff70f8 Compare July 2, 2020 21:52
@pitrou
Copy link
Member Author

pitrou commented Jul 2, 2020

Rebased.

wesm
wesm approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 556811c Jul 3, 2020
@pitrou pitrou deleted the ARROW-7010-cast-decimal-to-float branch July 3, 2020 13:27
@asfimport asfimport mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

@fsaintjacques fsaintjacques fsaintjacques approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou @wesm @fsaintjacques