Skip to content

ARROW-8934: [C++] Enable compute::Subtract with timestamp inputs to return duration #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesm wants to merge 2 commits into from
Closed

ARROW-8934: [C++] Enable compute::Subtract with timestamp inputs to return duration #7530

wesm wants to merge 2 commits into from

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jun 23, 2020

I also did a little bit of cleaning, moving some stuff into arrow::compute::internal.

wesm
wesm commented Jun 23, 2020
View reviewed changes
cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc

template <typename ArrowType>
class TestBinaryArithmetics : public TestBase {
class TestBinaryArithmetic : public TestBase {
Copy link
Member Author

@wesm wesm Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"arithmetics" is not correct, so many of the changes in this file are just this rename

@wesm
Copy link
Member Author

wesm commented Jun 23, 2020

Example use in Python:

In [14]: arr = pa.array(pd.date_range('2000-01-01', periods=20))                                                                                         

In [15]: arr2 = pa.array(pd.date_range('2000-01-10', periods=20))                                                                                        

In [16]: pc.subtract(arr, arr2)                                                                                                                          
Out[16]: 
<pyarrow.lib.DurationArray object at 0x7fc0005de0a8>
[
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000,
  -777600000000000
]

@github-actions
Copy link

github-actions bot commented Jun 23, 2020

https://issues.apache.org/jira/browse/ARROW-8934

@wesm
Copy link
Member Author

wesm commented Jun 24, 2020

+1

@wesm wesm closed this in dd94a58 Jun 24, 2020
@wesm wesm deleted the ARROW-8934 branch June 24, 2020 03:32
@asfimport asfimport mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesm