ARROW-9022: [C++] Add/Sub/Mul arithmetic kernels with overflow check #7420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
reviewed
Jun 12, 2020
kszucs
commented
Jun 15, 2020
| static enable_if_integer<T> Call(KernelContext* ctx, T left, T right) { | ||
| T result; | ||
| if (__builtin_add_overflow(left, right, &result)) { | ||
| ctx->SetStatus(Status::Invalid("overflow")); |
Member
Author
There was a problem hiding this comment.
Which error should we raise? ExecutionError?
Member
Author
|
Shall we have benchmarks for the new operators? |
wesm
approved these changes
Jun 18, 2020
| static enable_if_integer<T> Call(KernelContext* ctx, T left, T right) { | ||
| T result; | ||
| if (__builtin_add_overflow(left, right, &result)) { | ||
| ctx->SetStatus(Status::Invalid("overflow")); |
Member
|
@kszucs, yes, let's have benchmarks for the overflow operators, but can be done in a follow up PR |
kou
reviewed
Jun 19, 2020
| ARROW_EXPORT | ||
| Result<Datum> Add(const Datum& left, const Datum& right, ExecContext* ctx = NULLPTR); | ||
| Result<Datum> Add(const Datum& left, const Datum& right, | ||
| ArithmeticOptions options = ArithmeticOptions(), |
Member
There was a problem hiding this comment.
We need to document this.
This breaks CI: https://github.com/apache/arrow/runs/786249626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick draft for checked arithmetics.
TODOs:
*Checkedfunctions)