Skip to content

ARROW-8937: [C++] Implement strptime scalar string to timestamp kernel #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesm wants to merge 3 commits into from
Closed

ARROW-8937: [C++] Implement strptime scalar string to timestamp kernel #7312

wesm wants to merge 3 commits into from

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jun 1, 2020

For now, this is not exposed in any public APIs beyond using CallFunction to invoke it.

@github-actions
Copy link

github-actions bot commented Jun 1, 2020

https://issues.apache.org/jira/browse/ARROW-8937

pitrou
pitrou reviewed Jun 2, 2020
View reviewed changes
wesm and others added 2 commits June 2, 2020 09:58
@wesm
Implement strptime scalar string to timestamp kernel
d662edd 
Add a unit test for the OutputType::Resolve changes

Create kernels/test_util.cc
@wesm
Post-rebase fixes
8d071d5
@wesm
Copy link
Member Author

wesm commented Jun 2, 2020

+1. Will merge once CI is green

@wesm
Copy link
Member Author

wesm commented Jun 2, 2020

The ARM failure looks like a flake

/usr/bin/ccache /usr/bin/c++  -DARROW_EXPORTING -DARROW_HAVE_NEON -DARROW_HDFS -DARROW_JEMALLOC -DARROW_JEMALLOC_INCLUDE_DIR="" -DARROW_NO_DEPRECATED_API -DARROW_USE_GLOG -DARROW_WITH_BACKTRACE -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DURI_STATIC_BUILD -Isrc -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem /arrow/cpp/thirdparty/flatbuffers/include -isystem jemalloc_ep-prefix/src -isystem googletest_ep-prefix/include -isystem /arrow/cpp/thirdparty/hadoop/include -isystem orc_ep-install/include -Wno-noexcept-type  -fdiagnostics-color=always -ggdb -O0  -Wall -Wno-conversion -Wno-sign-conversion -Wno-unused-variable -Werror -march=armv8-a  -g -fPIC   -std=gnu++11 -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/vector_take.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/vector_take.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/vector_take.cc.o -c /arrow/cpp/src/arrow/compute/kernels/vector_take.cc
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

This may be related to code size -- some near-term refactoring I am undertaking in this file should address that

@wesm wesm closed this in 54885e0 Jun 2, 2020
@wesm wesm deleted the ARROW-8937 branch June 2, 2020 16:45
@asfimport asfimport mentioned this pull request Jun 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesm @pitrou