ARROW-8882: [C#] Add .editorconfig to C# code#7246
Closed
eerhardt wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-8882: [C#] Add .editorconfig to C# code#7246eerhardt wants to merge 3 commits intoapache:masterfrom
eerhardt wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
This is helpful, thanks @eerhardt! Editorconfig is preferable for those of us using VS Code on *nix. |
Contributor
Author
|
Also tagging @mr-smidge (sorry I forgot initially) |
stephentoub
approved these changes
May 22, 2020
Contributor
|
If there is a mechanism to fail the build with these rules I would recommend trying to add it to the list for check to avoid regressions |
Contributor
Author
There is an experimental package that hasn't been released yet that will allow for enforcement during the build: https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.CodeAnalysis.CSharp.CodeStyle When this feature is shipped, we can update to using it to start enforcement of code-style rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an
.editorconfigusing the rules from dotnet/runtime repo. See:Violating these rules won't fail the build, but Visual Studio will respect these rules when formatting the code and make suggestions.
The bulk of the violations were
varusages. There was one unnecessary usage ofthis.. And the rest were naming static fields withs_. InBitUtility.cs, I made a slight optimization using the pattern recognized by dotnet/roslyn#24621 instead of prefixing the fields withs_.Tagging anyone who has contributed to the C# library (please let me know if I missed anyone):
@chutchinson @zgramana @nhustler @HashidaTKS @abbotware @pgovind @stephentoub