Skip to content

ARROW-8664: [Java] Add flag to skip null check#7095

Closed
rymurr wants to merge 1 commit intoapache:masterfrom
rymurr:ARROW-8664
Closed

ARROW-8664: [Java] Add flag to skip null check#7095
rymurr wants to merge 1 commit intoapache:masterfrom
rymurr:ARROW-8664

Conversation

@rymurr
Copy link
Contributor

@rymurr rymurr commented May 4, 2020

All Vector containers should skip null check when null
check flag is enabled

All Vector containers should skip null check when null
check flag is enabled
@github-actions
Copy link

github-actions bot commented May 4, 2020

@rdblue
Copy link
Contributor

rdblue commented May 6, 2020

Looks good to me.

@wesm
Copy link
Member

wesm commented May 6, 2020

In the past adding a getUnsafe method was discussed. What do you think about that?

@jacques-n
Copy link
Contributor

This looks good to me. +1.

In the past adding a getUnsafe method was discussed. What do you think about that?

This ensures that the all methods are consistent with the current flag. I think the getUnsafe could make sense but seems like a separate thing.

@rymurr
Copy link
Contributor Author

rymurr commented May 8, 2020

This looks good to me. +1.

In the past adding a getUnsafe method was discussed. What do you think about that?

This ensures that the all methods are consistent with the current flag. I think the getUnsafe could make sense but seems like a separate thing.

Captured this in https://issues.apache.org/jira/browse/ARROW-8738

@emkornfield
Copy link
Contributor

Thanks @rymurr

@rymurr rymurr deleted the ARROW-8664 branch June 4, 2020 10:54
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
All Vector containers should skip null check when null
check flag is enabled

Closes apache#7095 from rymurr/ARROW-8664

Authored-by: Ryan Murray <rymurr@dremio.com>
Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants