ARROW-8132: [C++] Fix S3FileSystem tests on Windows #6632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@pitrou appveyor is failing |
The new Minio version is less robust when deleting directories.
29668ca to
1a41f43
Compare
Member
Author
|
Ok, I'm skipping some assertions on Windows. |
Member
Author
|
Bloody git checkout failure on GHA is back. |
Member
Author
|
AppVeyor build green both on my fork: https://ci.appveyor.com/project/pitrou/arrow/builds/31501196 and on the ASF account: https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/31501193 |
kszucs
approved these changes
Mar 16, 2020
Member
kszucs
left a comment
There was a problem hiding this comment.
LGTM, the failures are unrelated.
kszucs
reviewed
Mar 16, 2020
| bool have_directory_mtimes() const override { return false; } | ||
| bool have_flaky_directory_tree_deletion() const override { | ||
| #ifdef _WIN32 | ||
| // Recent Minio versions on Windows may not register deletion of all |
Member
There was a problem hiding this comment.
Created a follow-up JIRA to revisit this issue later https://issues.apache.org/jira/browse/ARROW-8134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Minio version is less robust when deleting directories.