GH-46373: [Python] Exercise fallback case on tests for parquet.read_table in case dataset is not available#46550
Merged
raulcd merged 2 commits intoapache:mainfrom May 26, 2025
Merged
Conversation
…read_table in case dataset is not available
|
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d028fa8. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Since we merged:
The fallback case were dataset is not available is not being tested on parquet.read_table (I did validate myself with a breakpoint).
What changes are included in this PR?
Adds a basic test that checks the exercises that code path and tests the read_table method from
ParquetFileinstead ofParquetDatasetin case dataset is not available.Are these changes tested?
Yes via CI.
Are there any user-facing changes?
No