GH-45584: [C++][Thirdparty] Bump zstd to v1.5.7 #45585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
|
Member
Author
|
@github-actions crossbow submit -g cpp -g wheel |
|
Revision: dad2a1b Submitted crossbow builds: ursacomputing/crossbow @ actions-e95c349169
|
Member
Author
pitrou
approved these changes
Feb 20, 2025
wgtmac
approved these changes
Feb 20, 2025
kou
approved these changes
Feb 20, 2025
Member
kou
left a comment
There was a problem hiding this comment.
+1
Windows wheel jobs are broken on main too.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0d6278f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 42 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Zstd now released 1.5.7: https://github.com/facebook/zstd/releases/tag/v1.5.7 . It has an optimization that it improves speed for small blocks
We have some scenerio for small blocks and compression, so zstd-1.5.7 might helps
What changes are included in this PR?
Change zstd to v1.5.7
Are these changes tested?
Covered by existing
Are there any user-facing changes?
no