GH-44237: [C#] Use stack allocated buffer when serializing decimal values#44238
Merged
CurtHagenlocher merged 1 commit intoapache:mainfrom Sep 26, 2024
Merged
Conversation
Span overrides for decimal.GetBits were added in .NET 5, and allow us to avoid a heap allocation for each decimal value serialized.
|
|
CurtHagenlocher
approved these changes
Sep 26, 2024
Contributor
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dcf0d8c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Span overrides for
decimal.GetBitswere added in .NET 5, and allow us to avoid a heap allocation for each decimal value serialized.Running a quick benchmark shows the expected reduction in allocations
Happy to check in some benchmarks for
DecimalUtilityif they might be useful in future, but thought I'd leave them out for now.If merged, will close #44237.