GH-39638: [Docs][R] Add r-universe instructions#44033
Conversation
eitsupi
left a comment
There was a problem hiding this comment.
The apache R-universe is managed here, but it seems unclear at this time whether it is for release builds or edge builds.
https://github.com/r-universe-org/apache.r-universe.dev
If it is for edge builds, R-multiverse may be more suitable for installing release builds.
Or it may be worth updating the apache universe to show the same version as the CRAN release.
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
Hmmm. Fair point. Let's wait for the arrow devs to weigh in. It may be easiest to keep the current managed repo and just remove the "development" language. |
|
Thanks for making this PR @grantmcdermott! Just to confirm, we do use it for release builds and not dev builds. This addition is still welcome though, just with that bit updated. |
amoeba
left a comment
There was a problem hiding this comment.
Some style/spelling changes. I agree with the sentiment to change the language about development versions to release here too but didn't include them now.
|
Thanks for the feedback all. I've actioned the requested changes (modulo the uppercase suggestion). Let me know if you want changes to the wording. Some other points/thoughts:
|
|
Maybe the PR title is needed updated to something like |
|
|
|
Good call @eitsupi, I've changed the title and updated the related issue too. These changes now look good to me @grantmcdermott, thanks. And to your point about potential further improvements, those are probably best as separate issue. @thisisnic do you want one more look at this PR? |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3eb4135. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Closes #39638