GH-43787: [C++] Register the new Opaque extension type by default#43788
Merged
rok merged 2 commits intoapache:mainfrom Aug 22, 2024
Merged
GH-43787: [C++] Register the new Opaque extension type by default#43788rok merged 2 commits intoapache:mainfrom
rok merged 2 commits intoapache:mainfrom
Conversation
d9d35cb to
7f83cdf
Compare
lidavidm
approved these changes
Aug 22, 2024
7f83cdf to
78cfb3e
Compare
joellubi
approved these changes
Aug 22, 2024
78cfb3e to
09fb602
Compare
09fb602 to
bcb697a
Compare
Member
Author
|
Fixed a minor nit in the |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b4f7efe. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #43787
Additionally, this adds
bool8extension type builds withARROW_JSON=falseas discussed hereRationale for this change
Canonical types should be registered by default if possible (except e.g. if they can't be compiled due to
ARROW_JSON=false).What changes are included in this PR?
This adds default registration for
opaque, changes whenbool8is built and moves all canonical tests under the same test target.Are these changes tested?
Changes are tested by previously existing tests.
Are there any user-facing changes?
opauewill now be registered by default andbool8will be present in caseARROW_JSON=falseat build time.