GH-43532: [Python] Remove usage of deprecated pkg_resources in setup.py#43602
GH-43532: [Python] Remove usage of deprecated pkg_resources in setup.py#43602pitrou merged 1 commit intoapache:mainfrom
Conversation
|
|
d1bce93 to
b700766
Compare
|
@jorisvandenbossche Could you take a look please, |
|
@tlm365 thanks for the PR!
While using It might also be that you could move the |
|
|
b700766 to
ba3d33a
Compare
ba3d33a to
e72dec2
Compare
e72dec2 to
61231b5
Compare
|
@github-actions crossbow submit -g python -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
left a comment
There was a problem hiding this comment.
LGTM, I'll just wait for CI results
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
61231b5 to
279d16d
Compare
|
I've rebased on git main, to run CI again. |
|
@github-actions crossbow submit -g python -g wheel |
|
Revision: 279d16d Submitted crossbow builds: ursacomputing/crossbow @ actions-5c561e1e95 |
|
CI failures are unrelated, I'll merge. Thanks a lot @tlm365 ! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3420c0d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 26 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Closes #43532.
What changes are included in this PR?
Remove deprecated
pkg_resources.resource_filename('numpy', 'core/include'), replace withnumpy.get_include()Are these changes tested?
Test by CI.
Are there any user-facing changes?
No